Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-429] Adjust icon background and margins #38

Merged
merged 2 commits into from
Jul 10, 2024
Merged

[FAU-429] Adjust icon background and margins #38

merged 2 commits into from
Jul 10, 2024

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Jul 10, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-429

What is the new behavior (if this is a feature change)?
Icon background is fixed. There also was a problem with indentations because icons were inside a paragraph tag. I couldn't see this issue locally, so I added a rule to remove padding from those paragraphs.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

@zhyian zhyian requested review from shvlv, amiut and o-samaras July 10, 2024 06:17
Copy link
Collaborator

@amiut amiut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of it

@zhyian zhyian merged commit 67b078a into main Jul 10, 2024
4 of 5 checks passed
@zhyian zhyian deleted the FAU-429 branch July 10, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants